From 92c067c9ed82c5a8cf2a19045cade41e32465662 Mon Sep 17 00:00:00 2001 From: AINDUSTRIES Date: Fri, 4 Oct 2024 22:49:00 +0200 Subject: [PATCH] small fixes (if player not exsits show ?) --- static/js/index.js | 8 ++++++++ static/js/results.js | 8 ++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/static/js/index.js b/static/js/index.js index daf8559..4ce1531 100644 --- a/static/js/index.js +++ b/static/js/index.js @@ -76,6 +76,10 @@ async function main() { } if (select.value === "other") { let otherInput = document.getElementById("other"); + if (otherInput.value === "") { + showMessage("Tu as sélectionné autre mais tu n'as pas donné de nom", "N'oublie pas de soit sélectioner une personne ou de mettre un nom dans ''Autre:''.", true, "warning"); + return; + } let otherInputLabel = document.getElementById("other_label"); let player = await fetch("/player", {method: "post", body: JSON.stringify({"name": otherInput.value})}).then(r => r.json()); let option = document.createElement("option"); @@ -106,6 +110,10 @@ async function main() { title.textContent = "Vote -"; if (select.value === "other") { let otherInput = document.getElementById("other"); + if (otherInput.value === "") { + showMessage("Tu as sélectionné autre mais tu n'as pas donné de nom", "N'oublie pas de soit sélectioner une personne ou de mettre un nom dans ''Autre:''.", true, "warning"); + return; + } let otherInputLabel = document.getElementById("other_label"); let player = await fetch("/player", {method: "post", body: JSON.stringify({"name": otherInput.value})}).then(r => r.json()); let option = document.createElement("option"); diff --git a/static/js/results.js b/static/js/results.js index ed4c5c5..838c5b9 100644 --- a/static/js/results.js +++ b/static/js/results.js @@ -23,7 +23,7 @@ function show_plus(id, votes, players) { const app = document.getElementById("app"); app.innerHTML = ""; let vote = votes[id]; - let player = ""; + let player = "?"; for (let i = 0; i < players.length; i++) { if (players[i].id === vote["plus_player_id"]) { player = players[i]["name"]; @@ -63,7 +63,7 @@ function show_minus(id, votes, players) { let vote = votes[id]; let nickname = vote["minus_nickname"]; let reason = vote["minus_reason"]; - let player = ""; + let player = "?"; for (let i = 0; i < players.length; i++) { if (players[i].id === vote["minus_player_id"]) { player = players[i]["name"]; @@ -122,7 +122,7 @@ async function show_results(players) { let counter = 0; for (let i = 0; i < plus.length; i++) { let p = plus[i]; - let player = ""; + let player = "?"; for (let i = 0; i < players.length; i++) { if (players[i].id === p[0]) { player = players[i]["name"]; @@ -149,7 +149,7 @@ async function show_results(players) { counter = 0; for (let i = 0; i < minus.length; i++) { let p = minus[i]; - let player = ""; + let player = "?"; for (let i = 0; i < players.length; i++) { if (players[i].id === p[0]) { player = players[i]["name"];