From 01c8248313ca3a003ca42a97daf8ec8d5dfc7ec9 Mon Sep 17 00:00:00 2001
From: AINDUSTRIES <contact.aindustries@gmail.com>
Date: Fri, 4 Oct 2024 17:05:39 +0200
Subject: [PATCH] bug fix: ids can be wrong if players added/deleted

---
 static/css/results.css |  5 ++---
 static/js/results.js   | 28 ++++++++++++++++++++++++----
 2 files changed, 26 insertions(+), 7 deletions(-)

diff --git a/static/css/results.css b/static/css/results.css
index 0c1f07d..7ea1742 100644
--- a/static/css/results.css
+++ b/static/css/results.css
@@ -26,9 +26,8 @@ body {
 }
 
 .app {
-    margin: auto;
-    margin-bottom: 60px;
-    height: calc(100dvh + 60px);
+    margin: auto auto 60px;
+    height: calc(100% + 60px);
     width: 100%;
     max-width: 500px;
 }
diff --git a/static/js/results.js b/static/js/results.js
index 3d2fbb4..ed4c5c5 100644
--- a/static/js/results.js
+++ b/static/js/results.js
@@ -23,7 +23,12 @@ function show_plus(id, votes, players) {
     const app = document.getElementById("app");
     app.innerHTML = "";
     let vote = votes[id];
-    let player = players[vote["plus_player_id"] - 1]["name"];
+    let player = "";
+    for (let i = 0; i < players.length; i++) {
+        if (players[i].id === vote["plus_player_id"]) {
+            player = players[i]["name"];
+        }
+    }
     let nickname = vote["plus_nickname"];
     let reason = vote["plus_reason"];
     let minus = document.createElement("button");
@@ -58,7 +63,12 @@ function show_minus(id, votes, players) {
     let vote = votes[id];
     let nickname = vote["minus_nickname"];
     let reason = vote["minus_reason"];
-    let player = players[vote["minus_player_id"] - 1]["name"];
+    let player = "";
+    for (let i = 0; i < players.length; i++) {
+        if (players[i].id === vote["minus_player_id"]) {
+            player = players[i]["name"];
+        }
+    }
     let next = document.createElement("button");
     if (id === votes.length - 1) {
         next.textContent = "Résultats";
@@ -112,7 +122,12 @@ async function show_results(players) {
     let counter = 0;
     for (let i = 0; i < plus.length; i++) {
         let p = plus[i];
-        let player = players[p[0] - 1]["name"];
+        let player = "";
+        for (let i = 0; i < players.length; i++) {
+            if (players[i].id === p[0]) {
+                player = players[i]["name"];
+            }
+        }
         let score = p[1];
         if (prev_score == null || score < prev_score) {
             counter += 1;
@@ -134,7 +149,12 @@ async function show_results(players) {
     counter = 0;
     for (let i = 0; i < minus.length; i++) {
         let p = minus[i];
-        let player = players[p[0] - 1]["name"];
+        let player = "";
+        for (let i = 0; i < players.length; i++) {
+            if (players[i].id === p[0]) {
+                player = players[i]["name"];
+            }
+        }
         let score = p[1];
         if (prev_score == null || score < prev_score) {
             counter += 1;